Svelte Login migration PT II #9626
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reusable OAuth login button components (GitHub and Google) for use on login/signup pages. Each button includes style and click logic for OAuth redirect.
Add Svelte components for handling redirect logic: - RedirectIfLoggedIn redirects authenticated users away from login/signup/reset pages. - RedirectIfNotFinalized redirects logged-in users missing required data to finalize account.
Refactor navigation components for new login/signup flow: - Navigation now uses webRoutes for login/signup links instead of direct link logic. - Remove old env-based login redirect logic from Navigation. - Home Header shows login/signup via webRoutes.
Update the app layout: - Provide the LoginService for downstream components. - Integrate RedirectIfNotFinalized component at the top-level. - Only show Navigation if not on commit/login/signup page.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Show a logged out friendly message and prompt if user is not logged in. Previously checked for recent projects regardless of login state.
Update project reviews and rules pages to check for logged-in user by USER_SERVICE and redirect home if not logged in, rather than by auth token. Also add refreshUser method to userService.ts to refresh user state and handle errors.
Add all new authentication/user-related pages. This commit includes: - Svelte-based login page - Finalize account page - Signup page - Resend confirmation email page - Password reset start and confirmation pages Each page handles its specific logic, error display, and integrates with LoginService or the OAuth buttons as required. Navigation links, redirects, and user states are managed according to the new auth flow.
Update root layout logic: - Refactor authentication + token restore on navigation. - Use webRoutes for logic around the home page for login state check, not just token.
estib-vega
force-pushed
the
svelte-login-migration-2
branch
from
958e3c8 to
a26bbfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description