feat(logging): add log_class parameter to runner log files configuration#5036
Open
Brend-Smits wants to merge 2 commits intomainfrom
Open
feat(logging): add log_class parameter to runner log files configuration#5036Brend-Smits wants to merge 2 commits intomainfrom
Brend-Smits wants to merge 2 commits intomainfrom
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logging configuration by introducing support for the
log_classproperty, allowing log groups to be created with either theSTANDARDorINFREQUENT_ACCESSclass. The change is applied throughout the configuration to ensure log groups and log files can specify their class, defaulting toSTANDARDif not set.Logging configuration enhancements:
log_classproperty (defaulting to"STANDARD") to therunner_log_filesandmulti_runner_configvariables invariables.tf,modules/runners/variables.tf, andmodules/multi-runner/variables.tfto allow specifying the log group class. [1] [2] [3]modules/runners/logging.tfto include thelog_classproperty for each log file, defaulting to"STANDARD".modules/runners/logging.tfto use the specifiedlog_classwhen creating log groups, and refactored the logic to group log files by both name and class.Documentation improvements:
runner_log_filesvariable to document the newlog_classproperty and its valid values.