-
Notifications
You must be signed in to change notification settings - Fork 62.1k
Update about-forks.md: move a non-difference out of the list of diffe… #38913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rences. Listing that set of properties of forks as a difference to duplicate repositories suggests that the latter didn't have their own members, branches, tags, labels, policies, issues, pull requests, discussions, actions, projects, and wikis - which is inaccurate and may be confusing to unknowing users.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
Thanks for opening a PR! That list item definitely looks out of place, but I would advise just deleting it rather than moving it. We're trying to move toward a more streamlined style in our "about" pages, and that just isn't essential information. If we're listing the differences between forked and duplicated repositories, then it can probably be assumed that things not listed aren't differences, and users can go read more in depth about forks to confirm, if necessary. |
For a beginner audience seeking to learn the basics about forks, that sentence is full of essential information -- it's just not a difference. I think the clarity it provides about forks (*) should be given somewhere at "About forks", since that's the obvious choice out of all pages listed at Working with forks . Where else would users expect to find those basics? Also, strictly forks aside, hinting at those properties being shared with dupes is a shortcut to understanding both. It prevents users from having to search and learn about those properties of forks and dupes separately, to only find out then by manual comparison how much they have in common. How about moving the sentence further up on the page? (*) (N. b.: If you haven't worked with forks (or even git) before and wonder how their members, branches, tags, labels, policies, issues, pull requests, discussions, actions, projects, and wikis, relate to upstream, those are real questions.) |
@GfEW Okay, I looked a little more and this is apparently the only place this information is stated explicitly, so...yeah, you're right. Maybe more of the articles about forks should be revised to put it in an article where it makes more sense, but that's not going to happen today. This is fine. 👍 I'll get it added to the merge queue once checks are passing. |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
…rences.
Listing that set of properties of forks as a difference to duplicate repositories suggests that the latter didn't have their own members, branches, tags, labels, policies, issues, pull requests, discussions, actions, projects, and wikis - which is inaccurate and may be confusing to unknowing users.
Why:
Closes: #38912
What's being changed (if available, include any code snippets, screenshots, or gifs):
Rearranged existing content to resolve a confusing inconsistency.
Check off the following: