Skip to content

Fix test skip mechanism and update leeway to v0.10.8 #21190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
geropl merged 10 commits into from
Jan 6, 2026
Merged

Fix test skip mechanism and update leeway to v0.10.8 #21190

geropl merged 10 commits into from
Jan 6, 2026

Conversation

@geropl
Copy link
Member

@geropl geropl commented Dec 10, 2025 •
edited
Loading

Description

This PR includes multiple fixes and updates:

  1. Fix test skip mechanism - Handle empty environment variables
  2. Update leeway - Upgrade from v0.10.6 to v0.10.8
  3. Enable immediate cache upload - Set LEEWAY_CACHE_UPLOAD_IMMEDIATE=true
  4. Fix installer dependency - Update outdated helm registry reference

Changes

Test Skip Mechanism Fix

The ifEnvVarNotSet utility was failing in CI because it only checked for undefined, but CI environments can set variables to empty strings. This caused tests to run without valid tokens, resulting in 401 errors.

Solution: Updated to check for both undefined and empty strings:

const value = process.env[name];
const skip = value === undefined || value === '';

Leeway Updates

  • Updated LEEWAY_VERSION from 0.10.6 → 0.10.7 → 0.10.8
  • Added LEEWAY_CACHE_UPLOAD_IMMEDIATE=true to enable new upload mechanism
  • Updated dev-environment image references throughout CI workflows

Installer Fix

  • Fixed dependency to outdated helm registry in docker-registry chart

Commits

  • Fix test skip mechanism to handle empty env vars
  • [content-service] Fix outdated test expectations
  • [dev] Drop "--ignore-scripts" for yarn
  • [dev] Update leeway to v0.10.7
  • [dev] Update leeway to v0.10.8
  • [dev] Update dev-environment images throughout CI
  • [installer] Fix dependency to outdated helm registry

Testing

  • Verified test skip logic handles all cases correctly
  • CI builds new dev-environment images with updated leeway versions
  • All workflow files updated to use latest dev-environment image

@geropl @ona-agent
Fix test skip mechanism to handle empty env vars
df23a62 
The ifEnvVarNotSet function was only checking for undefined, but in CI
environments variables can be set to empty strings. This caused tests
to run when they should have been skipped, resulting in 401 errors.

Now checks for both undefined and empty string values.

Co-authored-by: Ona <no-reply@ona.com>
@geropl geropl requested a review from a team as a code owner December 10, 2025 10:51
@geropl geropl force-pushed the fix/skip-if-empty-env-vars branch from 1072dc1 to efae4dd Compare December 11, 2025 13:11
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 21, 2025
@github-actions github-actions bot closed this Dec 26, 2025
@geropl @ona-agent
[dev] Update leeway to v0.10.7
eb608a5 
Co-authored-by: Ona <no-reply@ona.com>
@geropl geropl reopened this Jan 5, 2026
@geropl @ona-agent
[dev] Use new dev-image throughout CI: dev-environment:fix-skip-if-em…
d40d0af 
…pty-env-vars-gha.25

Co-authored-by: Ona <no-reply@ona.com>
@geropl @ona-agent
[dev] Update leeway to v0.10.8
ca3933b 
Co-authored-by: Ona <no-reply@ona.com>
@geropl @ona-agent
[dev] Use new dev-image throughout CI: dev-environment:fix-skip-if-em…
e7bb888 
…pty-env-vars-gha.29

Co-authored-by: Ona <no-reply@ona.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@geropl @ona-agent
[installer] Fix dependency to outdated helm registry
8be3715 
Co-authored-by: Ona <no-reply@ona.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@geropl geropl changed the title Fix test skip mechanism to handle empty env vars Fix test skip mechanism and update leeway to v0.10.8 Jan 6, 2026
@geropl geropl deployed to branch-build January 6, 2026 14:05 — with GitHub Actions Active
@geropl geropl enabled auto-merge January 6, 2026 14:09
@geropl geropl added this pull request to the merge queue Jan 6, 2026
@geropl geropl removed this pull request from the merge queue due to a manual request Jan 6, 2026
@geropl geropl added this pull request to the merge queue Jan 6, 2026
@Ona-Security-Admin Ona-Security-Admin removed this pull request from the merge queue due to the queue being cleared Jan 6, 2026
@geropl geropl merged commit 46ae2f5 into main Jan 6, 2026
28 checks passed
@geropl geropl deleted the fix/skip-if-empty-env-vars branch January 6, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corneliusludmann corneliusludmann corneliusludmann approved these changes

Assignees

No one assigned

Labels

meta: stale This issue/PR is stale and will be closed soon team: team-enterprise

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@geropl @corneliusludmann