Update git2 to 0.21 across crates#2962
Merged
Merged
Conversation
Collaborator
|
Awesome! Thank you! |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
git2dependency to 0.21.Among other things, this brings a new feature flag:
unstable-sha256. This feature flag is not enabled in this PR. This could be done in a follow-up.Breaking changes in upstream changelog: https://github.com/rust-lang/git2-rs/blob/main/CHANGELOG.md#changed
Relevant for
gitui:ssh,https, andcredCargo features are no longer enabled by default.”asyncgitnow explicitly enableshttps.Option<&str>now returnResult<&str, Error>orResult<Option<&str>, Error>, so callers can distinguish a missing value from a non-UTF-8 one.” In this PR, I’ve decided to keep the existing behaviour by treatingErrvalues asNone. Let me know if you want any changes here!