chore: cleanup logging

Author: activescott

airbyte-integrations/connectors/destination-glide/destination_glide/destination.py

@@ -16,7 +16,7 @@
 
 from .glide import Column, GlideBigTableFactory
 import json
-from .log import getLogger
+from .log import LOG_LEVEL_DEFAULT
 import logging
 import requests
 from typing import Any, Iterable, Mapping
@@ -25,7 +25,8 @@
 CONFIG_GLIDE_API_VERSION_DEFAULT = "tables"
 CONFIG_GLIDE_API_HOST_DEFAULT = "https://api.glideapp.io"
 
-logger = getLogger()
+logger = logging.getLogger(__name__)
+logger.setLevel(LOG_LEVEL_DEFAULT)
 
 
 def mapJsonSchemaTypeToGlideType(json_type: str) -> str:

airbyte-integrations/connectors/destination-glide/destination_glide/glide.py

@@ -1,10 +1,11 @@
 from abc import ABC, abstractmethod
+from .log import LOG_LEVEL_DEFAULT
+import logging
 import requests
 from typing import Dict, Any, Iterator, List
 
-from .log import getLogger
-
-logger = getLogger()
+logger = logging.getLogger(__name__)
+logger.setLevel(LOG_LEVEL_DEFAULT)
 
 BigTableRow = Dict[str, Any]
 
@@ -201,6 +202,7 @@ def finalize_stash(self) -> None:
             r.raise_for_status()
         except Exception as e:
             raise Exception(f"failed to finalize stash") from e  # nopep8
+        logger.info(f"Successfully finalized record stash for table '{self.table_id}' (stash ID '{self.stash_id}')")
 
     def commit(self) -> None:
         self.raise_if_set_schema_not_called()

airbyte-integrations/connectors/destination-glide/destination_glide/log.py

@@ -1,21 +1,4 @@
 
 import logging
 
-# Create a logger
-
-logger = logging.getLogger("destination-glide")
-logger.setLevel(logging.DEBUG)
-
-# Create a file handler
-# TODO REMOVE?
-handler = logging.FileHandler('destination-glide.log')
-handler.setLevel(logging.INFO)
-# Create a logging format
-formatter = logging.Formatter(
-    '%(asctime)s - %(name)s - %(levelname)s - %(message)s')
-handler.setFormatter(formatter)
-# Add the handlers to the logger
-logger.addHandler(handler)
-
-def getLogger() -> logging.Logger: 
-  return logger
+LOG_LEVEL_DEFAULT = logging.INFO

airbyte-integrations/connectors/destination-glide/todo.md

@@ -4,7 +4,7 @@
 - [+] fix: "add rows failed with status 400: {"message":"More than 500 mutations"}" in mutation api (batch them to ~100 or something)
 - [+] fix: batch row adds in rest api
 - [+] chore: unify test framework across unit/integration tests (remove pytest?)
-- [+] feat: snuggle rows in batch
+- [+] feat: snuggle rows in a batch
 - [ ] feat: support multiple streams from source by using a naming convention and discovering existing tables with GET /tables
 - [ ] fix: replace "hostname" and "path" configs with "baseUrl"
 - [ ] feat: verify actual host/api/auth connection in check: https://docs.airbyte.com/understanding-airbyte/airbyte-protocol#check

airbyte-integrations/connectors/destination-glide/unit_tests/destination_test.py

@@ -13,6 +13,7 @@
 from datetime import datetime
 from destination_glide import DestinationGlide
 from destination_glide.glide import GlideBigTableBase, GlideBigTableFactory
+from destination_glide.log import LOG_LEVEL_DEFAULT
 import json
 import logging
 import random
@@ -48,6 +49,7 @@ def table_schema() -> str:
 
 def AirbyteLogger() -> logging.Logger:
     logger = logging.getLogger('airbyte')
+    logger.setLevel(LOG_LEVEL_DEFAULT)
 
 
 def configured_catalog(test_table_name: str, table_schema: str) -> ConfiguredAirbyteCatalog: