Update last login when "remember_me" is used

Author: trasher

src/Auth.php

@@ -684,6 +684,7 @@ public function getAlternateAuthSystemsUserLogin($authtype = 0)
 
                         if (self::checkPassword($cookie_token, $hash)) {
                             $this->user->fields['name'] = $user->fields['name'];
+                            $user->update(['id' => $user->getID(), 'last_login' => $_SESSION["glpi_currenttime"]]);
                             return true;
                         } else {
                             $this->addToError(__("Invalid cookie data"));

tests/functional/AuthTest.php

@@ -309,4 +309,24 @@ public function testPasswordCostUpdate(): void
         preg_match('/\$2y\$(\d+)\$.+/', $user->fields['password'], $new_cost);
         $this->assertGreaterThan(5, (int) $new_cost[1]);
     }
+
+    public function testRememberMeLastLogin(): void
+    {
+        $_SESSION["glpi_currenttime"] = date('Y-m-d H:i:s');
+        $user = getItemByTypeName(User::class, 'post-only');
+        $token = $user->getAuthToken('cookie_token', true);
+        $this->assertnull($user->fields['last_login']);
+
+        $_COOKIE[session_name() . '_rememberme'] = json_encode([
+            $user->getID(),
+            $token,
+        ]);
+
+        //login using remember_me cookie just set
+        $this->assertTrue((new \Auth())->login('', ''));
+
+        //check if last_login is now set
+        $this->assertTrue($user->getFromDB($user->getID()));
+        $this->assertSame($_SESSION["glpi_currenttime"], $user->fields['last_login']);
+    }
 }