Support multibyte strings in RSQL #21845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mikhail-D <mikhail_dv@mail.ru>
2 tasks
trasher
reviewed
Nov 7, 2025
Contributor
trasher
left a comment
trasher
left a comment
There was a problem hiding this comment.
Seem OK. Please fix lint (tests failures are not related)
AdrienClairembault
approved these changes
Nov 17, 2025
cedric-anne
approved these changes
Nov 19, 2025
trasher
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Fixes #21807
Adds proper handling of multi-byte RSQL strings in the lexer.
Code was done by @Mikhail-D while the test was added by myself. Seems to be working OK.