Fix - Service Levels rule criterias #21973
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
requested changes
Nov 18, 2025
Member
cedric-anne
left a comment
cedric-anne
left a comment
There was a problem hiding this comment.
Could you rename the $action variable to $criteria?
cedric-anne
requested changes
Nov 18, 2025
Member
cedric-anne
left a comment
cedric-anne
left a comment
There was a problem hiding this comment.
Some unset() operations have to be reviewed. For instance, parent::getCriterias() does not return an entry with the affectobject key, so unset($actions['affectobject']); is not valid.
Also this issue seems to be also present on GLPI 10.0, so the fix should probably target the 10.0/bugfixes branch.
Contributor
Author
|
ping @stonebuzz @Rom1-B |
stonebuzz
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Fix incorrect method call in
LevelAgreementLevel::getCriterias().The method was calling
parent::getActions()instead ofparent::getCriterias(), which caused the wrong set of fields to be returned for escalation level criteria.