Skip to content

Prevent generic network asset to handle agents#24245

Merged
trasher merged 1 commit into
glpi-project:11.0/bugfixesfrom
trasher:fix/24217
May 19, 2026
Merged

Prevent generic network asset to handle agents#24245
trasher merged 1 commit into
glpi-project:11.0/bugfixesfrom
trasher:fix/24217

Conversation

@trasher
Copy link
Copy Markdown
Contributor

@trasher trasher commented May 18, 2026

closes #24217

@trasher trasher requested review from g-bougard and stonebuzz May 18, 2026 11:56
@trasher trasher force-pushed the fix/24217 branch 2 times, most recently from 7719642 to ada0652 Compare May 18, 2026 12:25
Comment thread src/Glpi/Asset/Capacity/IsInventoriableCapacity.php Outdated
Copy link
Copy Markdown
Member

@g-bougard g-bougard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually on my side and it seems to work as expected.

Thank you.

@trasher

This comment was marked as outdated.

@trasher trasher marked this pull request as draft May 18, 2026 14:08
@trasher trasher force-pushed the fix/24217 branch 3 times, most recently from 740d372 to 7d7bd93 Compare May 19, 2026 07:11
@trasher trasher marked this pull request as ready for review May 19, 2026 08:20
@trasher
Copy link
Copy Markdown
Contributor Author

trasher commented May 19, 2026

Everything should be OK now; ready for final review :)

@trasher trasher requested a review from Rom1-B May 19, 2026 08:20
Copy link
Copy Markdown
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g-bougard
Copy link
Copy Markdown
Member

Just tested updated patch on 11.0.7 and it still works as expected.
Thank you

@trasher trasher merged commit 00dc6b3 into glpi-project:11.0/bugfixes May 19, 2026
20 of 21 checks passed
@trasher trasher deleted the fix/24217 branch May 19, 2026 09:37
@cedric-anne cedric-anne added this to the 11.0.8 milestone May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agent should not be linked to a custom asset generated from a networking xml inventory

4 participants