Skip to content

Conversation

sanyam188
Copy link

No description provided.

@srbcheema1
Copy link
Contributor

good catch @sanyam188, just one more change. it is good to discover other cases than given in the discription of issue. I have written that it fails on empty file but that was not the only problem. I have left the other cases for the solvers. you did really well by finding out the location of the problem.
The other cases are that it will also fail on file size less than 5 words (not only empty file). Sometimes it happens that issue reporter reports the issue with less information it is duty of contributers to detect the root cause of problem and try to fix all the cases including those not listed in issue

Good luck and I hope to see another commit over this PR :)

@sanyam188
Copy link
Author

sanyam188 commented Sep 28, 2018 via email

@srbcheema1
Copy link
Contributor

Great @sanyam188
I will be eagerly waiting for your next commit.
just a bonus tip: never miss writing PR description

Happy Contributing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants