When the lock timer creation fails, delete lock_obj #4604
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@atinmu @sanjurakonde |
JamesWSWu
force-pushed
the
issue4603
branch
2 times, most recently
from
c236f8b to
5d2e8f6
Compare
mykaul
reviewed
Jul 29, 2025
| gf_msg(this->name, GF_LOG_ERROR, 0, GD_MSG_DICT_SET_FAILED, | ||
| "Unable to set timer in mgmt_v3 lock"); | ||
| keylen = strlen(key_dup); | ||
| dict_deln(priv->mgmt_v3_lock, key_dup, keylen); |
Contributor
There was a problem hiding this comment.
Shouldn't you also free 'lock_obj' ?
nit: the whole keylen and such and using dict_deln() - you could just use dict_del()
Contributor
Author
There was a problem hiding this comment.
@mykaul I have made modifications based on the suggestions. Please review it again.
Thanks!
Signed-off-by: 10255046 <wu.shiwei@zte.com.cn>
Contributor
Author
Contributor
Member
|
I will take a look when I get some time. Bit busy with one migration at work. Will take a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the lock timer creation fails, we may delete lock_obj. To prevent permanent occupation by lock owners
Fixes: #4603