fix: Add missing error checks to functions #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinoosss
reviewed
Sep 23, 2025
Signed-off-by: Lee ByeongJun <lbj199874@gmail.com>
Signed-off-by: Lee ByeongJun <lbj199874@gmail.com>
jinoosss
approved these changes
Oct 14, 2025
Signed-off-by: Lee ByeongJun <lbj199874@gmail.com>
|
jinoosss
pushed a commit
that referenced
this pull request
Oct 15, 2025
* fix: error checks * fix parameter mismatch * fix missing error checks * fix * remove unnecessary codes (position) * fix --------- Signed-off-by: Lee ByeongJun <lbj199874@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added error checks to functions that were missing error validation.
swapInner, no changes were made as it has been replaced with the common.safeGRC20Approve function.Except for these two cases, error checks have been added according to the recommendations.