Upgrade to lestrrat-go/jwx/v3 #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes please, this brings issues! |
|
@plutov Heya! Just had a look and you had the same issue I had, but i did get the tests working in the end 🙈 I fixed it by this replacement :) - // NewSignatureAlgorithm creates a new SignatureAlgorithm object with the given name.
- jwa.NewSignatureAlgorithm
+ // LookupSignatureAlgorithm returns the SignatureAlgorithm object for the given name.
+ jwa.LookupSignatureAlgorithm |
- Upgrade Go version to 1.24.3 - Update lestrrat-go/jwx/v3 to version 3.0.2 - Upgrade golang.org/x/crypto to version 0.38.0 and golang.org/x/sys to version 0.33.0 - Refactor JWT claim extraction in jwtauth.go and jwtauth_test.go to use transform.AsMap for improved readability and error handling.
plutov
approved these changes
Jun 3, 2025
|
@kw510 please also change the version in the example file. |
VojtechVitek
reviewed
Jun 3, 2025
- Downgrade Go version in go.mod to 1.23.0 - Update RSA private and public keys in jwtauth_test.go for improved security and compatibility - Adjust token string in TestSimpleRSAVerifyOnly for consistency
|
@VojtechVitek @kw510 let's merge it ? ;) |
VojtechVitek
approved these changes
Jul 17, 2025
|
Hey @VojtechVitek I tested it on a project where it was originally failing, but now it works well. Looks good from my side! |
|
@VojtechVitek how is testing going? Why this merge takes so long? |
|
Same question as @plutov: I've been holding off updating some libraries because of this PR. What's the status? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies to use v3 of lestrrat-go/jwx and related packages
Refactor JWT handling in tests and main code for compatibility with new API.