Skip to content

Cannot request changes on own PR #34478

Open
@ascendise

Description

@ascendise

Description

I tried to create a review on my own PR, so it blocks the PR from merging before issues are resolved.
I noticed that I wasn't able to add myself as a reviewer, but I was able to go to the file changes and add comments to lines and start a review.

When I tried to submit the review, "Approve" and "Request Changes" were greyed out and not clickable. Hovering over it tells me, that I am not able to review my own PR. I can comment my review and it added all the things I noticed to the issue, but it does not block the PR from getting merged. (I have set a branch protection rule with "Block merge on rejected reviews")

Image

#7289

This old issue was closed, because it seemed like it worked and was just a visual issue (I wasn't able to click the button)
I did try to just enable the button with some "Inspect Element"-magic and click it that way, but was greeted with this error and my PR still mergable.

Image

I am not sure if this is just not supported, but that would be a bummer, as I don't see any harm in being able to review yourself

Gitea Version

1.23.8

Can you reproduce the bug on the Gitea demo site?

Did not try there, yet

Log Gist

No response

Screenshots

No response

Git Version

2.47.2

Operating System

Alpine 3.21.3

How are you running Gitea?

Deployed with docker

Database

SQLite

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue/not-a-bugThe reported issue is the intended behavior or the problem is not inside Gitea

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions