Support external renderers to PDF (#17635) #21098
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was always attempted to read the file to be rendered as UTF-8. The encoding was determined heuristically, regardless of the file type. Sometimes binary files were not recognized as binary. Renderers of binary formats were then fed with corrupted data: binary stream treated as text and encoded in UTF-8. Only apply heuristics for textual formats, read other formats as-is. Fixes: b01dce2 ("Allow render HTML with css/js external links (go-gitea#19017)") Cc: xiaolunwen@gmail.com Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
For some formats, conversion to HTML is unavailable or lossy, while quality conversion of printing to PDF is available. Examples include Office PPTX slides and TeX papers. Add new option value markup.XXX.RENDER_CONTENT_MODE = "pdf". It requires markup.XXX.NEED_POSTPROCESS = false. In this mode, external renderer is only invoked for the standalone page. Embedded rendering outputs a PDF.js widget with a link to that page. Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
lunny
added
the
type/feature
techknowlogick
requested changes
Sep 7, 2022
GiteaBot
added
the
lgtm/need 2
Maybe consider with this one together. |
|
Should fix #17635 |
|
Implemented by Make external iframe render work #35730 |
wxiaoguang
added a commit
that referenced
this pull request
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some formats, conversion to HTML is unavailable or lossy, while quality conversion of printing to PDF is available.
Examples include Office PPTX slides and TeX papers.
Add new option value markup.XXX.RENDER_CONTENT_MODE = "pdf".
It requires markup.XXX.NEED_POSTPROCESS = false.
In this mode, external renderer is only invoked for the standalone page.
Embedded rendering outputs a PDF.js widget with a link to that page.
The first commit is a required fix for this PR, although not limited to it.