Refactor CSRF protector #32057
Merged
Refactor CSRF protector #32057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
wxiaoguang
force-pushed
the
refactor-csrf
branch
2 times, most recently
from
8574918 to
fef4ddf
Compare
wxiaoguang
force-pushed
the
refactor-csrf
branch
from
fef4ddf to
d8789da
Compare
lunny
approved these changes
Sep 17, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Sep 17, 2024
wolfogre
approved these changes
Sep 18, 2024
GiteaBot
added
lgtm/done
|
I was unable to create a backport for 1.22. @wxiaoguang, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Sep 18, 2024
lunny
pushed a commit
that referenced
this pull request
Sep 18, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 19, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix: database not update release when using `git push --tags --force` (go-gitea#32040) Resolve duplicate local string key related to PR comments (go-gitea#32073) Refactor CSRF protector (go-gitea#32057)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused CSRF options, decouple "new csrf protector" and "prepare" logic, do not redirect to home page if CSRF validation falis (it shouldn't happen in daily usage, if it happens, redirecting to home doesn't help either but just makes the problem more complex for "fetch")