Skip to content

Make it possible to delete stale review requests that incorrectly remain in DB #33356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Make it possible to delete stale review requests that incorrectly remain in DB #33356

wants to merge 36 commits into from
+93 −27

Conversation

@6543
Copy link
Member

@6543 6543 commented Jan 22, 2025 •
edited
Loading

... filter dismissed via SQL more

for tests just create this database entry:

id type dissmissed
1 4 0
2 3 1

currently I discover this edgecases in the wild :/

with this patch the review request can still be deleted

Sponsored by Kithara Software GmbH

@6543 6543 added the type/bug label Jan 22, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 22, 2025
@lunny
Copy link
Member

lunny commented Jan 22, 2025

Could you add some tests?

@6543 6543 changed the title Make it possible to delete stale review requests that incorrectly remain in DB WIP: Make it possible to delete stale review requests that incorrectly remain in DB Jan 22, 2025
6543
6543 commented Sep 1, 2025
View reviewed changes
6543
6543 commented Sep 1, 2025
View reviewed changes
6543
6543 commented Sep 1, 2025
View reviewed changes
6543
6543 commented Sep 1, 2025
View reviewed changes
@6543
Update models/issues/pull_test.go
9154b6c 
Signed-off-by: 6543 <6543@obermui.de>
@6543 6543 changed the title WIP: Make it possible to delete stale review requests that incorrectly remain in DB Make it possible to delete stale review requests that incorrectly remain in DB Sep 1, 2025
@6543 6543 requested a review from lunny September 1, 2025 15:01
lunny
lunny reviewed Sep 7, 2025
View reviewed changes
lunny
lunny reviewed Sep 7, 2025
View reviewed changes
lunny
lunny reviewed Sep 7, 2025
View reviewed changes
@6543 6543 mentioned this pull request Sep 8, 2025
Open
6 tasks
@6543 6543 mentioned this pull request Sep 16, 2025
Open
@6543 6543 requested a review from lunny September 16, 2025 14:24
@6543 6543 requested a review from techknowlogick September 18, 2025 07:50
@6543
Copy link
Member Author

6543 commented Oct 1, 2025 •
edited
Loading

@lunny I did add the tests ...

lunny
lunny reviewed Oct 2, 2025
View reviewed changes
@6543 6543 requested a review from lunny October 2, 2025 03:02
lunny
lunny reviewed Oct 4, 2025
View reviewed changes
@6543 6543 requested a review from lunny October 6, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

@lunny lunny Awaiting requested review from lunny

Assignees

No one assigned

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@6543 @lunny @techknowlogick @GiteaBot