Skip to content

Make external iframe render work #35730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 23, 2025
Merged

Make external iframe render work #35730

merged 6 commits into from
Oct 23, 2025

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 23, 2025 •
edited
Loading

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/frontend labels Oct 23, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Oct 23, 2025 •
edited
Loading

image
image

@wxiaoguang wxiaoguang mentioned this pull request Oct 23, 2025
Closed
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Oct 23, 2025
@wxiaoguang wxiaoguang added this to the 1.26.0 milestone Oct 23, 2025
@wxiaoguang wxiaoguang mentioned this pull request Oct 23, 2025
Closed
@wxiaoguang wxiaoguang mentioned this pull request Oct 23, 2025
Merged
silverwind
silverwind reviewed Oct 23, 2025
View reviewed changes
silverwind
silverwind approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a hack but it's probably ok given that iframes are always tricky to work with.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 23, 2025
@github-actions github-actions bot added the docs-update-needed The document needs to be updated synchronously label Oct 23, 2025
@wxiaoguang wxiaoguang mentioned this pull request Oct 23, 2025
Closed
@wxiaoguang
Copy link
Contributor Author

Will merge and backport since it is a bug fix, and the old default behaviors are not changed, new behaviors are covered by tests.

@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Oct 23, 2025
@wxiaoguang wxiaoguang added the backport/manual No power to the bots! Create your backport yourself! label Oct 23, 2025
silverwind
silverwind reviewed Oct 23, 2025
View reviewed changes
silverwind
silverwind reviewed Oct 23, 2025
View reviewed changes
@wxiaoguang wxiaoguang enabled auto-merge (squash) October 23, 2025 07:45
@wxiaoguang wxiaoguang merged commit 522c466 into go-gitea:main Oct 23, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-render-iframe branch October 23, 2025 08:02
@wxiaoguang wxiaoguang mentioned this pull request Oct 23, 2025
Closed
wxiaoguang added a commit that referenced this pull request Oct 23, 2025
@wxiaoguang
Fix external render, make iframe render work (#35727, #35730) (#35731)
b2f2f85 
Backport #35727 and #35730

---------

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.25 docs-update-needed The document needs to be updated synchronously lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Markup with RENDER_CONTENT_MODE=iframe always has zero height

4 participants

@wxiaoguang @lunny @silverwind @GiteaBot