Skip to content

Misc tool tweaks #35734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2025
Merged

Misc tool tweaks #35734

merged 3 commits into from
Oct 23, 2025
+9 −14

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Oct 23, 2025 •
edited
Loading

Some minor tooling tweaks:

  • Ignore .venv in golangci-lint
  • Move go tools to tools directory (e.g. everything that is not "build")
  • Enable reportUnusedInlineConfigs in eslint, no current violations
  • Apply modernize fix in code-batch-process, modernize cli did apparently not catch it because of the go:build ignore tag.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 23, 2025
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 23, 2025
@silverwind silverwind enabled auto-merge (squash) October 23, 2025 08:06
@silverwind silverwind merged commit e03a68c into go-gitea:main Oct 23, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 23, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 23, 2025
wxiaoguang
wxiaoguang reviewed Oct 24, 2025
View reviewed changes
tools/code-batch-process.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be moved together.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, codeformat folder needs to move to tools.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#35758

@wxiaoguang wxiaoguang deleted the misc branch October 24, 2025 00:26
@silverwind silverwind mentioned this pull request Oct 27, 2025
Merged
silverwind added a commit that referenced this pull request Oct 28, 2025
@silverwind @wxiaoguang
Move codeformat folder to tools (#35758)
91839ca 
Followup to #35734.

- Move `codeformat` folder to `tools`
- Add `tools` to `GO_DIRS`
- Move `misspellings.csv` to `assets` so we can lint the whole `tools`
directory without filter shenanigans.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/internal topic/code-linting

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

5 participants

@silverwind @lunny @wxiaoguang @delvh @GiteaBot