Skip to content

Conversation

@dangjinghao
Copy link

For better readability, display more [mailer] configuration options on the admin/config page.

  • Display more [mailer] configuration options
  • If an option is not set, it will be hidden
  • Display User option only when SMTP enabled. Because it is only used in SMTP mode
  • Refer to the mailer section cheatsheet
  1. dummy mode:
dummy
  1. sendmail mode
image
  1. smtp mode with many options
smtp_with_many_configurations
  1. smtp mode with a few options
smtp_a_few_configurations

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 14, 2025
@github-actions github-actions bot added modifies/translation modifies/templates This PR modifies the template files labels Nov 14, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 14, 2025

There are hundreds of config options.

Without a complete design, the "config" page shouldn't show anything more.


What users really need is to lint the config file and find mistakes, but not read a page which is filled by hundreds of config options again.

@wxiaoguang wxiaoguang marked this pull request as draft November 14, 2025 16:59
@dangjinghao
Copy link
Author

From my testing, the FROM field is required to run dummy and sendmail modes. So I think it would be better to add it.

I've also noticed that the USER field, which should be exclusive to SMTP, is mistakenly displayed in all modes.

At least, we might want to consider fix both of these.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 14, 2025

From my testing, the FROM field is required to run dummy and sendmail modes. So I think it would be better to add it.

You should have been warned, the error log is clearer than the unclear UI. Even if you show FROM on the UI, reader doesn't know that what it should be.

image

I've also noticed that the USER field, which should be exclusive to SMTP, is mistakenly displayed in all modes.

There are far more mistakes, not only this one. Fixing or not, maybe there is no difference, unless there is a complete design to resolve the problem fundamentally

@dangjinghao
Copy link
Author

Understood. Thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/templates This PR modifies the template files modifies/translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants