Merge pull request #47 from System-Glitch/develop

v2.8.0

Author: System-Glitch

.github/workflows/test.yml

@@ -34,8 +34,9 @@ jobs:
         go get github.com/client9/misspell/cmd/misspell
         go get github.com/rakyll/gotest
 
-    - name: Verify MySQL connection
+    - name: Start MySQL
       run: |
+        sudo /etc/init.d/mysql start
         while ! mysqladmin ping --silent; do
           sleep 1
         done
@@ -49,7 +50,7 @@ jobs:
     - name: Test
       run: |
         gotest -race -count=20 .
-        gotest -v -race -coverprofile=coverage.txt -covermode=atomic -coverpkg=./... ./...
+        gotest -v -p 1 -race -coverprofile=coverage.txt -covermode=atomic -coverpkg=./... ./...
         go vet $(go list ./...)
         golint -set_exit_status $(go list ./...)
         gocyclo -over 15 .

config/config.go

@@ -100,8 +100,8 @@ func Load() error {
 		panic(err)
 	}
 
-	if !validateConfig() {
-		return fmt.Errorf("Invalid config")
+	if err := validateConfig(); err != nil {
+		return err
 	}
 
 	return err
@@ -242,16 +242,20 @@ func getConfigFilePath() string {
 	return "config." + env + ".json"
 }
 
-func validateConfig() bool {
+func validateConfig() error {
+	message := "Invalid config:"
 	valid := true
 	for key, value := range config {
 		if err := validateEntry(value, key); err != nil {
-			fmt.Fprintln(os.Stderr, err)
+			message += "\n- " + err.Error()
 			valid = false
 		}
 	}
 
-	return valid
+	if !valid {
+		return fmt.Errorf(message)
+	}
+	return nil
 }
 
 func validateEntry(value interface{}, key string) error {

config/config_test.go

@@ -97,7 +97,9 @@ func (suite *ConfigTestSuite) TestInvalidConfig() {
 	val := Get("appName")
 
 	config["appName"] = true
-	suite.False(validateConfig())
+	err := validateConfig()
+	suite.NotNil(err)
+	suite.Equal("Invalid config:\n- Invalid config entry: \"appName\" type must be string", err.Error())
 	config["appName"] = val
 
 	suite.Panics(func() {