Skip to content

Commit 09fdb95

Browse files
m.abramovichchristophwitzko
authored andcommitted
fix(create-release): valid release sha checking if it is not valid(for example branch name)
1 parent 5da822b commit 09fdb95

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pkg/provider/git.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,10 @@ func (repo *Repository) GetReleases(rawRe string) ([]*semrel.Release, error) {
164164
}
165165

166166
func (repo *Repository) CreateRelease(release *provider.CreateReleaseConfig) error {
167-
hash := plumbing.NewHash(release.SHA)
168-
if hash.IsZero() {
167+
var hash plumbing.Hash
168+
if plumbing.IsHash(release.SHA) {
169+
hash = plumbing.NewHash(release.SHA)
170+
} else {
169171
// hash is not valid, let's assume it is a branch name
170172
resolvedRef, err := repo.repo.Reference(plumbing.NewBranchReferenceName(release.SHA), true)
171173
if err != nil {

0 commit comments

Comments
 (0)