Fix concurrent writes to stdout in tests. #2350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trulede
changed the title
pd93
approved these changes
Aug 5, 2025
Member
pd93
left a comment
pd93
left a comment
There was a problem hiding this comment.
Nice! This has been bothering me for a while. Thanks for investigating.
andreynering
requested changes
Aug 7, 2025
✅ Deploy Preview for next-taskfile canceled.
|
trulede
changed the title
trulede
force-pushed
the
PR/deps_stdout
branch
from
985e1ba to
05b1764
Compare
andreynering
approved these changes
Nov 11, 2025
Member
andreynering
added a commit
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes to stdout from
depsare occasionally "mixed up" because of stdout buffering. To prevent this, the entire grouped output is written with one call togw.buffer.WriteString()rather than the previous two calls.Additionally, to reduce flaky tests, use a SyncBuffer which prevents interleaving of stdout/err (typically from
depswhich run in parallel).fixes #2349
fixes #1208