`run: when_changed` not deduping properly in some cases

[bennieswart]

Description

Consider the following files in which the reusable task is included from multiple locations.

# Taskfile.yml

version: '3'

includes:
  lib:
    taskfile: Taskfile.lib.yml
  other:
    taskfile: Taskfile.other.yml

tasks:
  all:
    deps:
      # Both run for same vars
      - task: lib:reusable
        vars:
          V: x
      - task: other:lib:reusable
        vars:
          V: x

      # Both run for same vars
      - task: lib:reusable
        vars:
          V: y
      - task: other:lib:reusable
        vars:
          V: y

      # These don't run; properly deduped.
      - task: lib:reusable
        vars:
          V: x
      - task: other:lib:reusable
        vars:
          V: x
      - task: lib:reusable
        vars:
          V: y
      - task: other:lib:reusable
        vars:
          V: y

# Taskfile.other.yml

version: '3'

includes:
  lib:
    taskfile: Taskfile.lib.yml

# Taskfile.lib.yml

version: '3'

tasks:
  reusable:
    cmd: echo running reusable with V={{.V}}
    run: when_changed
    # label has no effect
    label: reusable-{{.V}}

Running this gives the following output:

$ task all
task: [reusable-x] echo running reusable with V=x
task: [reusable-x] echo running reusable with V=x
task: [reusable-y] echo running reusable with V=y
task: [reusable-y] echo running reusable with V=y
running reusable with V=x
running reusable with V=y
running reusable with V=x
running reusable with V=y

The expected output is:

$ task all
task: [reusable-x] echo running reusable with V=x
task: [reusable-y] echo running reusable with V=y
running reusable with V=x
running reusable with V=y

This minimal(ish) example is distilled from a part of my setup where I have a reusable task to install dependencies (node/python etc) in a directory. The path is given with a variable and the expectation is that the task only runs once per directory. I'm pretty sure that run: when_changed shouldn't behave differently based on the way it was included (main -> lib vs main -> other -> lib).

Version

3.45.4

Operating system

ubuntu:24.04 (docker container)

Experiments Enabled

No response

Example Taskfile

[trulede]

You might be able to get this to work by "removing" ast.Task.Namespace from the hash generation which I think causes what you observe (since each time the task is imported it gets a new namespace).

You might confirm that by importing with "flatten: true" which should not set the namespace ... or change the code above.

It could be that your problem represents a new use-case to consider, rather than a defect with the existing when_changed operation.