FIx calculation of task.Dir for tasks in included taskfiles. #2445
Conversation
trulede
force-pushed
the
PR/include_dir
branch
from
76beeaa to
cdfb74d
Compare
when the task is compiled the task.Dir can be determined using the template cache (not available when the AST is being constructed).
trulede
force-pushed
the
PR/include_dir
branch
from
cdfb74d to
598e69b
Compare
|
@andreynering @vmaerten In this PR I've relocated the point where an imported task.Dir is calculated, and as a result it is possible to use template variables in the However, some tests (2) are proving to be remarkably flakey. These are sometimes passing, sometimes failing. These test cases have two imported Taskfiles, each with the same global var You might have ideas why that is the case? It seems unrelated to the effects of #2350, and somehow related to this PR. In either case I would likely add some additinal testcases to cover the change in functionality added by this PR. |
|
Hey @trulede! First of all, thanks for your patience! I know if have many PRs opened and we are overdue on reviewing them. I debugged this flaky test a little bit, but couldn't quickly find the problem, and want to focus on other PRs for today. But to add context, this was originally fixed by @pd93 on the following PR, and your changes probably made that fix insufficient for some reason. |
|
@andreynering OK, thanks. I will take a look. |
2 participants
Relocate the calculation of an included tasks task.Dir until the templating is available.
Previously, task.DIr would be calculated earlier which resulted in SmartJoin() incorrectly evaluating the second parameter, which had not been expanded (i.e. {{.FOO}}. To get correct behaviour, SmartJoin() needed to be called later, during compilation of the imported task, so that the second parameter could first be expanded, and then used correctly with SmartJoin().
fixes #2443
fixes #2497
fixes #1690
fixes #951