Fixing issues with subtasks in filtered views. 1. Subtasks that match…#2676
Open
v-marinkov wants to merge 3 commits into
Open
Fixing issues with subtasks in filtered views. 1. Subtasks that match…#2676v-marinkov wants to merge 3 commits into
v-marinkov wants to merge 3 commits into
Conversation
…ed a filter were missing if their parent task did not match the filter. 2. Subtasks that did not match a filter were incorrectly shown if their parent task matched the filter. 3. Subtasks were visually duplicated in the list, appearing both nested under their parent and independently at the root level.
github-actions
Bot
added
area/filters
Preview DeploymentPreview deployments for this PR are available at:
The preview environment will start automatically on first visit. Subsequent pushes to this PR will update the Run locally with Dockerdocker pull ghcr.io/go-vikunja/vikunja:pr-2676
docker run -p 3456:3456 ghcr.io/go-vikunja/vikunja:pr-2676Last updated for commit 220af19 |
|
Just tested the PR preview and can confirm that this fixes #2646 as well. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the following bugs for subtasks in saved filters:
The core issue stems from how the
expand=subtaskslogic interacts with filtered views.expand=subtaskswas originally designed for unfiltered lists to isolate root tasks and recursively fetch their children. When applied to filtered views, it aggressively stripped out matching subtasks (bug #1) and indiscriminately pulled in non-matching subtasks via its recursive SQL query (bug #2).Bug #3 was reintroduced after a regression that fixed #1786 so the PR reverts back to that fix.
I have tested the app locally and the filtering with subtasks now works perfectly in saved filters. Namely: