Skip to content

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 15, 2025

PKCE was already kinda implemented for the twitter source, this makes it configurable and adds S256 support

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners October 15, 2025 13:35
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit b03ba10
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68f0ce53564f4600087c2134

Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit b03ba10
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68f0ce53fc671b00082d4990

Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit b03ba10
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68f0ce53fe73d70008ba6c1c

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.93%. Comparing base (06bfcf0) to head (b03ba10).
⚠️ Report is 13 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/sources/oauth/clients/oauth2.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17487   +/-   ##
=======================================
  Coverage   92.92%   92.93%           
=======================================
  Files         868      868           
  Lines       47833    47906   +73     
=======================================
+ Hits        44448    44520   +72     
- Misses       3385     3386    +1     
Flag Coverage Δ
e2e 45.19% <44.64%> (-0.03%) ⬇️
integration 23.18% <25.00%> (-0.01%) ⬇️
unit 91.07% <96.42%> (+0.01%) ⬆️
unit-migrate 91.12% <96.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 15, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-b03ba102a267881f455545580ef124abf6ec95fd
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-b03ba102a267881f455545580ef124abf6ec95fd

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the sources/oauth/configurable-pkce branch from 41e92f8 to b03ba10 Compare October 16, 2025 10:52
@BeryJu BeryJu merged commit 2484f28 into main Oct 16, 2025
99 checks passed
@BeryJu BeryJu deleted the sources/oauth/configurable-pkce branch October 16, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant