Try to remove duplicate type argument from base set#1985
Draft
Try to remove duplicate type argument from base set#1985
set#1985Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
setfunctions in base have twotyparguments:lval_type, which is a fallback for when sometypeOfcalculation fails, e.g. for alloc variables.t_override, which is used instead of thetypeOfcalculation, e.g. for the return variable.This is quite confusing and seems excessive.
lval_typeis always provided from some version oftypeOfanyway, so that argument might be redundant.In this PR, I started to refactor it, but so far did not manage to get all the way. Different places get the
lval_typefrom different things, e.g.Cilfacade.typeOfLvalandAD.type_of(which is kind of non-deterministic!).It's not clear whether the differences are intentional (i.e., these different functions compute different things in some cases) or accidental.