-
Notifications
You must be signed in to change notification settings - Fork 69
[WIP] Full Site Editing #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| "https://downloads.wordpress.org/plugin/woocommerce.latest-stable.zip", | ||
| "https://downloads.wordpress.org/plugin/create-block-theme.latest-stable.zip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing here seems off. Also, please speak to why we would include create-block-theme in the .wp-env.json file. I presume this may be related to testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The create-block-theme plugin is not just for testing but for development which is why included it. It will help anyone modifying styles and/or templates to work inside the site editor and export directly to the local directory and then commit to our repo.
| ), | ||
| array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh dang. I just realized these layouts are going away. Historically the Layout Selector in CB has depended on these layouts from Go. The LS will be rather useless once GSE comes out. We should probably move these to CoBlocks, right? Otherwise, we should deprecate the control like Site Design - this time not because of compatibility but because of its value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call out! We can keep these in Go and I will restore them. The layout selector could still be relevant but we can also expose these inside the patterns explorer in Core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CICD Pipeline updates are looking good. 👍 ✅
A few questions posted up and tests will need to be addressed later, but looking good.
Co-authored-by: JR Tashjian <jrtashjian@gmail.com> Co-authored-by: Evan Herman <evan.m.herman@gmail.com>
This PR transitions Go from a Classic theme into a Full Site Editing supported Block theme.
Migration from Customizer
Site Identity:
Site logo
Site icon
Site title
Hide site title toggle
hide_site_titleTagline
hide_site_taglineHide tagline toggle
Site Design
Design syles (Traditional, Modern, Trendy, Welcoming, Playful)
design_styleColor palette (Primary, Secondary, Tertiary, Background)
primary_color,secondary_color,tertiary_color,background_colorHeader colors (Background, Foreground)
header_text_color,header_background_colorFooter colors (Background, Foreground)
footer_text_color,footer_background_colorSocial icon
social_icon_colorHeader
Header variations (1-7)
header_variationSticky header toggle
sticky_headerFooter
footer_variationSocial
social_icon_{network}Menus
Site Settings
Page titles toggle
page_titlesBlog excerpt toggle
blog_excerptCopyright text
copyrightMigration from Site Design in CoBlocks Labs
Font Pairings
Ensure that the font pairings are migrated correctly.
Heading font, weight, size (rem)
fonts[ {font_name}_heading ]: [ {font_weight} ]type_ratio. The rem size is calculated from the ratio and the body font size.Body font, weight, size (rem)
fonts[ {font_name}_body ]: [ {font_weight} ]font_sizeFont Familes
These are the font families and weights we need to bundle with Go.
What to test
Colors, sizings, spacings, typography. There will be visual changes but if there are any obvious discrepancies, we should take a closer look and possibly fix them.
Migration from classic to block templates. Basically we want to test that customizations made in the classic theme's customizer are translated into the block templates and global styles of FSE. This is not setup to be automatic yet but passing the
migrateurl param will trigger the migration. You can switch between themasterbranch and this branch (full-site-editing) to test.Reporting issues
Create an issue with the "Full Site Editing" label and assign me (the link autofills these details).