Skip to content

Pages have more than one H1 tag #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pages have more than one H1 tag #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .dev/tests/php/test-template-tags.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1439,7 +1439,7 @@ public function test_site_branding_custom_logo_h1() {

set_theme_mod( 'custom_logo', $featured_image_id );

$this->expectOutputRegex( '/<h1 class="custom-logo"><a href="http:\/\/localhost:8889\/" class="custom-logo-link" rel="home">(<img)([^<]*|[^>]*)(.*\/>)<\/a><\/h1>/' );
$this->expectOutputRegex( '/<div class="custom-logo"><a href="http:\/\/localhost:8889\/" class="custom-logo-link" rel="home">(<img)([^<]*|[^>]*)(.*\/>)<\/a><\/div>/' );

Go\site_branding();

Expand Down
4 changes: 2 additions & 2 deletions includes/template-tags.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,13 +842,13 @@ function site_branding( $args = array() ) {
if ( function_exists( 'the_custom_logo' ) && has_custom_logo() ) {

/**
* Wrap the custom logo in an h1 element when the hiding the site title & tagline.
* Wrap the custom logo in a div container when hiding the site title & tagline.
*/
add_filter(
'get_custom_logo',
function ( $html ) use ( $hide_title ) {

return $hide_title ? '<h1 class="custom-logo">' . $html . '</h1>' : $html;
return $hide_title ? '<div class="custom-logo">' . $html . '</div>' : $html;
},
PHP_INT_MAX
);
Expand Down