Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

Port over paint kit hero widget #170

Merged
merged 21 commits into from
Feb 28, 2017
Merged

Port over paint kit hero widget #170

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
e365bac
Port over paint kit hero widget
Feb 24, 2017
03e0c7f
Fix spacing
Feb 24, 2017
c71ecda
Convert array syntax to be compatible with php 5.2
Feb 24, 2017
5f35f99
Fix docblock
Feb 24, 2017
9eae439
Add phpcs ruleset to ignore blank line found after control structure
Feb 24, 2017
7e310a2
Change rules
Feb 24, 2017
ab55a8f
Fixing php 5.2 anonymous func
Feb 24, 2017
8714a56
Fix commenting
Feb 24, 2017
31e81af
Refactor anonymour func to use callback instead
Feb 24, 2017
4b9fd94
Fix old style array and use call_user_func
Feb 24, 2017
bbc1cb4
Remove base class and consolidate logic top hero widget
Feb 26, 2017
3cf1b87
Remove uneeded common properties
Feb 26, 2017
37714ec
Add return statement
Feb 27, 2017
7d60f59
Refactor by Frankie
frankiejarrett Feb 28, 2017
c9f9d9e
Merge in develop
frankiejarrett Feb 28, 2017
7949c7a
Rename everything to "hero-text"
frankiejarrett Feb 28, 2017
ee34ece
Update comment for why inline script exists
frankiejarrett Feb 28, 2017
8493ba4
Print admin scripts in footer from widget form method
frankiejarrett Feb 28, 2017
b219815
Add context to widget title string
frankiejarrett Feb 28, 2017
510aba7
Merge in develop
frankiejarrett Feb 28, 2017
bb961a0
Change input type back to text
frankiejarrett Feb 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inc/hero-text-widget.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public function form( $instance ) {
<script>
( function ( $ ) {

// This let us know that we appended a new widget to reset sortables.
// Let our script know a widget has been added to make its URL search input work.
Copy link
Contributor

@frankiejarrett frankiejarrett Feb 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanbardo I updated the comment here to better clarify why the inline script exists.

$( document ).trigger( 'primer.widgets.change' );

} )( jQuery );
Expand Down