Ensure source maps are not included in built plugins #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://godaddy-corp.atlassian.net/browse/MWC-18446
Summary
Our intention has always been to not ship sourcemap files in production code, and as part of that we attempt to strip the sourcemap comments from minified files.
At some point the comment style must have changed and it was no longer getting stripped. I think they went from
/*style comments to//style in JS, and that accounts for the change.Rather than accounting for the new comment format I opted to implement the
TODOmethod of not generating them at all if we're in thebuildordeploytasks.QA
sake compile/*# sourceMappingURL=wc-customer-order-csv-export-admin.min.css.map *///# sourceMappingURL=wc-customer-order-csv-export-admin.min.js.mapsake buildbuild/directorybuild/directory