Merge pull request #276 from skyverge/fix-gateways-settings-warning

Fix a PHP warning in 7.2 from the gateway settings

Author: ChaseWiseman

woocommerce/payment-gateway/class-sv-wc-payment-gateway.php

@@ -3134,19 +3134,25 @@ protected function add_authorization_charge_form_fields( $form_fields ) {
 		}
 
 		// get a list of the "paid" status names
-		$paid_statuses = array_map( 'wc_get_order_status_name', SV_WC_Plugin_Compatibility::wc_get_is_paid_statuses() );
+		$paid_statuses = array_map( 'wc_get_order_status_name', (array) SV_WC_Plugin_Compatibility::wc_get_is_paid_statuses() );
 
 		// do some oxford comma magic
-		$last_status = array_pop( $paid_statuses );
-		array_push( $paid_statuses, "or {$last_status}" );
-		$separator = count( $last_status ) < 3 ? ' ' : ', ';
+		if ( count( $paid_statuses ) > 1 ) {
+
+			$last_status = array_pop( $paid_statuses );
+
+			/* translators: a conjuction used in the list of order status names, such as "Processing, Completed, or Shipped" */
+			array_push( $paid_statuses, __( 'or', 'woocommerce-plugin-framework' ) . ' ' . $last_status );
+		}
+
+		$separator = count( $paid_statuses ) < 3 ? ' ' : ', ';
 
 		$form_fields['enable_paid_capture'] = array(
 			'label'       => __( 'Capture Paid Orders', 'woocommerce-plugin-framework' ),
 			'type'        => 'checkbox',
 			'description' => sprintf(
 				__( 'Automatically capture orders when they are changed to %s.', 'woocommerce-plugin-framework' ),
-				implode( $separator, $paid_statuses )
+				esc_html( ! empty( $paid_statuses ) ? implode( $separator, $paid_statuses ) : __( 'a paid status', 'woocommerce-plugin-framework' ) )
 		 	),
 			'default' => 'no',
 		);