fix: add integer overflow protection with minimal performance impact #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SetMaxStackAllocItemSize: Clamp values to [0, 1MB] range using std::max/min - EstimateAsherahOutputSize: Add overflow check only for suspiciously large data (>1TB) - AllocationSizeToMaxDataSize: Add buffer underflow check with unlikely branch hint All fixes use performance-conscious approaches with branch prediction hints
jgowdy-godaddy
force-pushed
the
fix-integer-overflow-issues
branch
from
ce0c45e to
866042c
Compare
jgowdy-godaddy
force-pushed
the
fix-integer-overflow-issues
branch
from
8e29030 to
70c5c05
Compare
Force use of installed Go version (1.24.0) instead of allowing automatic download of Go 1.24.1 which causes version mismatch errors in CI.
Prevent version conflict error when dry-running npm publish since the package.json version is 0.0.0 but published version is 3.0.8.
Fix arm64 build failure caused by undefined unlikely() macro. The scoped_allocate.h file uses unlikely() but didn't include hints.h where the macro is defined.
The CI npm version requires a tag when the package.json version (0.0.0) is lower than the published version (3.0.8), even for dry-run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Performance Impact
unlikely())Test plan
🤖 Generated with Claude Code