Skip to content

Commit 6facde3

Browse files
authored
Merge pull request #1602 from Faless/build/use_clang_cl_is_use_llvm
[SCons] Remove use_clang_cl windows flag in favor of generic use_llvm
2 parents 709bad0 + 4717a78 commit 6facde3

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tools/windows.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,9 @@ def options(opts):
7676
mingw = os.getenv("MINGW_PREFIX", "")
7777

7878
opts.Add(BoolVariable("use_mingw", "Use the MinGW compiler instead of MSVC - only effective on Windows", False))
79-
opts.Add(BoolVariable("use_clang_cl", "Use the clang driver instead of MSVC - only effective on Windows", False))
8079
opts.Add(BoolVariable("use_static_cpp", "Link MinGW/MSVC C++ runtime libraries statically", True))
8180
opts.Add(BoolVariable("silence_msvc", "Silence MSVC's cl/link stdout bloat, redirecting errors to stderr.", True))
82-
opts.Add(BoolVariable("use_llvm", "Use the LLVM compiler", False))
81+
opts.Add(BoolVariable("use_llvm", "Use the LLVM compiler (MVSC or MinGW depending on the use_mingw flag)", False))
8382
opts.Add("mingw_prefix", "MinGW prefix", mingw)
8483

8584

@@ -114,7 +113,7 @@ def generate(env):
114113
env.Append(CCFLAGS=["/utf-8"])
115114
env.Append(LINKFLAGS=["/WX"])
116115

117-
if env["use_clang_cl"]:
116+
if env["use_llvm"]:
118117
env["CC"] = "clang-cl"
119118
env["CXX"] = "clang-cl"
120119

0 commit comments

Comments
 (0)