Skip to content

Cherrypicks "[SCons] Enable WASM_BIGINT in web builds" into 4.3 branch #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fwsGonzo
Copy link

@fwsGonzo fwsGonzo commented Oct 5, 2024

This was marked as cherrypick-4.3 in the original PR #1603

Godot Sandbox and godot-sqlite are among the known extensions needing this for Web export to function

Required since Godot 4.3, which is also the first Godot version with
wide WASM gdnative support (previous versions were Chrome-only, and very
brittle).
@fwsGonzo fwsGonzo requested a review from a team as a code owner October 5, 2024 19:05
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed this so probably want another approve to avoid bias.

Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My project also only runs on web with this patch.

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 28, 2024

I've got this one in the next batch cherry-picking PR #1632 as well

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 30, 2024

This was merged with PR #1632

@dsnopek dsnopek closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants