-
-
Notifications
You must be signed in to change notification settings - Fork 642
Typed dictionary initializer support #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typed dictionary initializer support #1750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This looks just like the equivalent code in Godot, so I'd be inclined to approve it, but there is one difference that I'd like to clear up first
18dba36
to
2efb83a
Compare
I'll bringing up the missing Also, like I mentioned on another of your PRs, before this can be merged it needs to get squashed down to a single commit: https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#the-interactive-rebase |
2efb83a
to
4ffea9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slated for merge on the main repo & this implementation mirrors that nicely
EDIT: Now merged on the main repo!
4ffea9e
to
335b490
Compare
Updated PR to add in changes from godotengine/godot#104664 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Allows for the following syntax: