CMake: re-add /RTC1 removal fix #1751
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add msvcHack.cmake to consolidate funky business Move the runtime library fix into the same location The RTC fix was present in 4.3 and below, it somehow got lost in a rebase perhaps.
|
Might this just be hiding a real bug tho... I'm seeing a few weird stacktraces around. |
|
Yeah, I think we probably want these extra runtime checks in debug builds. Whether or not we want them in release builds is open to discussion, but it sounds like cmake is only adding them to debug builds by default anyway? |
correct. I will close this PR now we have a proper solution to the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RTC fix was present in 4.3 and below, it somehow got lost, in a rebase perhaps.
CMake adds /RTC1 to MSVC Debug builds by default, and running the test integration fails
It doesnt show up in CI because we build in Release mode which doesnt add this flag.
Debug is necessary to compile with debug symbols.