Skip to content

Stop referring to GDExtension as experimental in the README #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Apr 1, 2025

Per the discussion at the previous GDExtension meeting, we think it's time to stop saying that GDExtension is experimental :-)

While I guess we technically still reserve the right to break compatibility if there is a bug or issue serious enough, based on our track record so far, I don't think we will need to.

This PR replaces the warning about being experimental, with some of the text copied from this docs page:

https://docs.godotengine.org/en/latest/tutorials/scripting/gdextension/what_is_gdextension.html#version-compatibility

I think we should ultimately just link to that docs page, so we don't have to update this information in two places, however, I don't want to link to it with godotengine/godot-docs#10631 still open, because that will lead to the URL changing.

Also, for this reason, I didn't integrating more of the suggestions from #1588 and instead decided to keep it minimal, because all of the notes we talked about there probably should be on the docs page rather than in the godot-cpp README

@dsnopek dsnopek added enhancement This is an enhancement on the current functionality documentation cherrypick:4.3 cherrypick:4.4 labels Apr 1, 2025
@dsnopek dsnopek added this to the 4.x milestone Apr 1, 2025
@dsnopek dsnopek requested a review from a team as a code owner April 1, 2025 19:24
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great wording!

Copy link
Contributor

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, GDExtension having such a good track record definitely deserves being seen as more stable! 😊

@dsnopek dsnopek force-pushed the not-experimental-any-more branch from e78606e to 7660dd2 Compare April 4, 2025 14:12
@dsnopek
Copy link
Collaborator Author

dsnopek commented May 2, 2025

Now that PR godotengine/godot-docs#10827 is merged, I'm going to merge this one as well!

@dsnopek dsnopek merged commit 681fb04 into godotengine:master May 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.3 cherrypick:4.4 documentation enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants