-
-
Notifications
You must be signed in to change notification settings - Fork 642
SCons: Add CPPEXTPATH
for external includes
#1756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This seems to match the Godot code, but it's a little beyond my scons and build knowledge to really review. If someone more knowledgeable can take a look, that'd be amazing; otherwise, I trust @Repiteo's expertise in this area and would be fine to go forward even without :-)
Does this need equivalent cmake changes? cc @enetheru
4a748bf
to
cbd32a6
Compare
No changes needed for CMake. |
cbd32a6
to
30bfa6f
Compare
Oh? I really need to do a proper deep-dive into CMake at some point to get a feel for how that buildsystem operates, because that might be an even better method than what I've attempted here! I'm still sticking with this implementation to match the main repo for now, but that gives me something to think on. |
Hm, yeah, from the perspective of the consumer, godot-cpp's includes are themselves external |
Happy to get on a screen share and talk you through my undertanding, and provide links to useful videos and resources. |
@Repiteo Does this make any includes external, or just add the ability to do so? |
This only adds the ability to do so. I would be able to make the Godot text servers GDExtension implementations use them though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust @Repiteo's expertise in this area :-)
CPPEXTPATH
for external includes godot#104893Will enable SCons scripts to declare certain includes are external/system explicitly, for the sake of supressing warnings. Not too relevant in this isolated context, where we don't really care about warnings, but will prove useful for anything deriving from us (eg: the main repo's GDExtension text servers)