Skip to content

Use Math::abs to avoid ambiguity with integer abs #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Use Math::abs to avoid ambiguity with integer abs #1767

merged 1 commit into from
Apr 15, 2025

Conversation

Zylann
Copy link
Collaborator

@Zylann Zylann commented Apr 14, 2025 •
edited
Loading

That happened when compiling with Clang on Linux and -Wall https://github.com/Zylann/godot_voxel/actions/runs/14456040422/job/40539389673

@Zylann Zylann requested a review from a team as a code owner April 14, 2025 21:48
@Zylann Zylann mentioned this pull request Apr 14, 2025
Merged
@Ivorforce Ivorforce added bug This has been identified as a bug and removed bug This has been identified as a bug labels Apr 14, 2025
@dsnopek dsnopek added bug This has been identified as a bug cherrypick:4.4 labels Apr 15, 2025
@dsnopek dsnopek merged commit 94a8fad into godotengine:master Apr 15, 2025
4 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented Apr 15, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rburing rburing rburing approved these changes

@aaronfranke aaronfranke aaronfranke approved these changes

@Ivorforce Ivorforce Ivorforce approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug cherrypick:4.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zylann @dsnopek @rburing @aaronfranke @Ivorforce