Skip to content

Add specular occlusion documentation to StandardMaterial3D tutorial #10996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LunaCapra
Copy link
Contributor

@LunaCapra LunaCapra commented Jun 5, 2025

This adds documentation for both the "Disable Specular Occlusion" toggle as well as bent normal maps.

@Calinou Calinou added enhancement topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:3d labels Jun 5, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit large for the documentation. Here's a version compressed to 264 KB:
spatial_material_bentnormals.zip

It's very slightly lossy (WebP at quality 100 and preprocess dithering enabled to reduce banding), but is more than twice as small.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be zoomed or cropped in way more, so that it's easier to focus on the differences. Especially on smaller screens this helps

Comment on lines 447 to 450
* The bent normal map needs to use the X+, Y+ and Z+ coordinates, this is
known as OpenGL style. If you've imported a material made to be used with
another engine it may be DirectX style, in which case the bent normal map
needs to be converted so its Y axis is flipped.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The bent normal map needs to use the X+, Y+ and Z+ coordinates, this is
known as OpenGL style. If you've imported a material made to be used with
another engine it may be DirectX style, in which case the bent normal map
needs to be converted so its Y axis is flipped.
* The bent normal map needs to use the X+, Y+ and Z+ coordinates, which is
known as OpenGL-style. If you've imported a material made to be used with
another engine, it may be DirectX-style. In this case, the bent normal map
needs to be converted so its Y axis is flipped. This can be achieved by
checking **Normal Map Invert Y** in the Import dock.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal Map Invert Y in the import settings seems to be marked as deprecated in v4.5 dev5 and it says that the same result can be achieved by setting the green channel mapping to inverted green instead. Should I document that instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'd point to the new setting.

@LunaCapra LunaCapra force-pushed the specular-occlusion branch from 6f3d0b0 to b4fc492 Compare June 5, 2025 22:03
@LunaCapra LunaCapra force-pushed the specular-occlusion branch from b4fc492 to 659cdae Compare June 6, 2025 10:26
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good to me

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We should probably include instructions on baking bent normal maps from various programs in a future PR, as the process for doing so is much less standardized (and less well-documented) than standard normal maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:rendering topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants