Skip to content

Fix type of 'what' parameter to _Notifications In C# usage example #11008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ptlis
Copy link

@ptlis ptlis commented Jun 9, 2025

The type is wrong in the example ¯_(ツ)_/¯

Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the .NET documentation!

I've reviewed the change, and while the current example certainly needs a fix (so thanks for spotting that!), there are a couple of adjustments needed.

@raulsntos raulsntos added bug topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jun 10, 2025
ptlis and others added 2 commits June 10, 2025 18:42
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
@ptlis
Copy link
Author

ptlis commented Jun 10, 2025

Hi, thanks for that - as you probably guessed I ended up not needing to use this, but was tripped up nevertheless in my exploratory coding.

I've updated the PR to include both requested changes.

Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants