[3.6] Add C# code examples in Using signals
#7945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
added
enhancement
topic:dotnet
area:getting started
raulsntos
requested changes
Sep 18, 2023
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
whtsht
force-pushed
the
3.6-update-getting-started
branch
3 times, most recently
from
4adbf63 to
cf315fb
Compare
Remove `EventHandler` suffix Co-authored-by: Raul Santos <raulsntos@gmail.com> Remove `EventHandler` suffix Remove `EventHandler` suffix Co-authored-by: Raul Santos <raulsntos@gmail.com> update
Match code examples Match code examples u Apply suggestions from code review Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
whtsht
force-pushed
the
3.6-update-getting-started
branch
2 times, most recently
from
e085f8e to
eb779b7
Compare
AThousandShips
changed the title
Using signalsUsing signals
raulsntos
reviewed
Sep 21, 2023
Co-authored-by: Raul Santos <raulsntos@gmail.com>
whtsht
changed the title
Using signalsUsing signals
This was referenced Sep 27, 2023
|
The changes can be cherry-picked into the 3.5/3.4 branches, the file is identical to 3.6, no need to open separate PR's. I will close the other 2 as superseded by this one, as this PR is reviewed. (For cherry-pick: Please cherry pick into 3.4 then removing the 3.5 label, we don't have a 3.4 label anymore) |
AThousandShips
approved these changes
Nov 9, 2023
|
Thanks! Congrats on your first merged PR! I did a squash and merge for this PR but in the future please try and keep everything to 1 commit, if you don't know how to do that we have a guide here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from this issue
Using signals. #7917