-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update android SDK and Java version [3.6] #9747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
avirahmandev
commented
Aug 14, 2024
- Update Java version from 11 to 17
- Update target SDK from 33 to 34 according to Google's requirements for publishing on the Play Store
What does the error mean? This is the first PR I've done, I don't know much about it yet |
They are unrelated to your additions, they are errors in the spell check system that haven't been fixed in 3.x yet, see: Though there is one that is a proper typo, but regardless it's unrelated to your PR, see: |
Thanks! for the information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the update!
Build issue was fixed so I just rebased your PR so it would build correctly. Congrats on your first merged PR! Some advice for the future, when making a PR don't use your master or 3.6 branch, you'll want to fork them, not doing that makes updating your fork of the docs very hard. In addition please keep PRs to 1 commit, I did a squash and merge this time but keep that in mind for the future. If you haven't used git before we have a guide here. |
Thanks! for your merge & advice, very insightful, learned a lot here to start contributing to godot! |