Skip to content

Conversation

avirahmandev
Copy link

  • Update Java version from 11 to 17
  • Update target SDK from 33 to 34 according to Google's requirements for publishing on the Play Store

@AThousandShips AThousandShips requested a review from a team August 14, 2024 09:14
@AThousandShips AThousandShips added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:export enhancement labels Aug 14, 2024
@AThousandShips AThousandShips added this to the 3.x milestone Aug 14, 2024
@avirahmandev
Copy link
Author

What does the error mean? This is the first PR I've done, I don't know much about it yet

@AThousandShips
Copy link
Member

AThousandShips commented Aug 14, 2024

They are unrelated to your additions, they are errors in the spell check system that haven't been fixed in 3.x yet, see:

Though there is one that is a proper typo, but regardless it's unrelated to your PR, see:

@avirahmandev
Copy link
Author

Thanks! for the information

@avirahmandev avirahmandev requested a review from m4gr3d August 14, 2024 18:04
@avirahmandev avirahmandev requested a review from m4gr3d August 16, 2024 10:25
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the update!

@skyace65 skyace65 merged commit 7fc8c84 into godotengine:3.6 Aug 22, 2024
1 check passed
@skyace65
Copy link
Contributor

Build issue was fixed so I just rebased your PR so it would build correctly. Congrats on your first merged PR!

Some advice for the future, when making a PR don't use your master or 3.6 branch, you'll want to fork them, not doing that makes updating your fork of the docs very hard. In addition please keep PRs to 1 commit, I did a squash and merge this time but keep that in mind for the future. If you haven't used git before we have a guide here.

@avirahmandev
Copy link
Author

Build issue was fixed so I just rebased your PR so it would build correctly. Congrats on your first merged PR!

Some advice for the future, when making a PR don't use your master or 3.6 branch, you'll want to fork them, not doing that makes updating your fork of the docs very hard. In addition please keep PRs to 1 commit, I did a squash and merge this time but keep that in mind for the future. If you haven't used git before we have a guide here.

Thanks! for your merge & advice, very insightful, learned a lot here to start contributing to godot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants