Add missing initializer_list constructor to TypedDictionary#104664
Conversation
initializer_list constructor for TypedDictionary
|
Originally added in #99751 |
initializer_list constructor for TypedDictionaryinitializer_list constructor to TypedDictionary
|
We should probably add tests for this like there are already for standard |
Added some tests |
c520a37 to
df97060
Compare
|
There doesn't need to be a separate typed dictionary test file; typed tests already happen in the normal dictionary file, so those can be relocated there instead |
df97060 to
9c5b8a6
Compare
I thought it would be nicer to have tests for each class in their own test file, but no worries, I've moved them into the dictionary test file |
Calinou
left a comment
There was a problem hiding this comment.
Code and tests look good to me.
9c5b8a6 to
8a3f984
Compare
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Noticed while adding initializer_list support to godot-cpp godotengine/godot-cpp#1750
This PR adds initializer list support to dictionarys for object and refcounted types, less useful in Godot, but will be very useful in gdextensions, it just needs to get merged here first.
After this PR goes in, I also want to add support for object and refcounted types as dictionary keys, this PR currently only supports them as values.