Fix doc theme not updating on NOTIFICATION_THEME_CHANGED in EditorHelp #105720
+6
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:editor
cherrypick:4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in-editor documentation pages check to update their theme when editor settings are changed (ie when a theme is set manually).
However, the docs do not perform this check on the "theme changed" notification, so they fail to update when the theme changes by other means, such as when the system theme changes while
interface/theme/follow_system_themeis enabled.This PR merges the
NOTIFICATION_EDITOR_SETTINGS_CHANGEDbehavior into theNOTIFICATION_THEME_CHANGEDcase so that the theme is always properly updated.For reference, here is a screenshot of the incorrect behavior, captured after switching the system theme from light mode to dark mode, with
interface/theme/follow_system_themeenabled (macOS 15.4, latestmaster1f787b6):