Remove unnecessary StringName idx cache in _Data to reduce its size.
#105760
Conversation
…size by 4 bytes. Encapsulate `StringName` details in its cpp file.
Ivorforce
force-pushed
the
string-name-encapsulate
branch
from
9110bcf to
3b31636
Compare
| bool StringName::_Data::operator!=(const char *p_name) const { | ||
| return !operator==(p_name); | ||
| } | ||
| static inline _Data *table[TABLE_LEN]; |
There was a problem hiding this comment.
Does static inline _Data *table[TABLE_LEN] = {}; not 0 initialize it, so we could remove the setup call altogether ?
There was a problem hiding this comment.
It would. But it's out of scope. It probably makes sense to allocate at runtime anyway to avoid the 500kb bloating the binary.
There was a problem hiding this comment.
I thought standard forced static arrays to be zero initialized anyway, but I'm not sure with inline. And it would probably be put in the bss section, so it would not bloat anything (but making sure no compiler options is messing with that would be the no fun part)
There was a problem hiding this comment.
And it would probably be put in the bss section, so it would not bloat anything (but making sure no compiler options is messing with that would be the no fun part)
I'm pretty sure bloaty told me the table made up 500kb of the final binary. I was planning on testing this again (along with potential speed impact) when I prepare the according PR.
I thought standard forced static arrays to be zero initialized anyway, but I'm not sure with inline.
Makes sense to me! inline in this case just means it is defined where it's declared (and doesn't have to be put into the cpp), so that shouldn't have any effect.
|
Thanks! |
The size is reduced by 8 bytes in DEBUG, and 0 bytes (no change) in RELEASE - both because of padding.
I'm also taking the opportunity to encapsulate
StringNamedetails in its cpp file (same as in #104372), and doing some other cleanup that doesn't warrant an entire pull request.This allows making changes to the table (such as changing size) internally without having everything be recompiled.