Android: Fix Android plugins regression #108243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plugins. Address a regression introduced in godotengine#102866. The proper behavior for Android plugins is to use `getContext` instead of `getActivity`, but since not all plugins follow this pattern, this fix provides backward compat to avoid breaking the plugins that don't.
m4gr3d
changed the title
primaryHost prior to initializing the registered Android plugins
Member
|
Note: issue #108193 was closed 6 hours ago, is this PR still valid? |
Contributor
Author
Yes it is. The current solution requires changes to existing Android plugins. |
Alex2782
approved these changes
Jul 3, 2025
|
Thank you so much for this. Is it safe to cherry pick this. This is blocking our Google Play Store Release. |
Contributor
|
This shouldn't need to be cherry-picked if the regression was introduced by #102866 which has only been in since 4.5-beta1. After it's merged, it will be included in the next 4.5-beta release |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address a regression introduced in #102866.
The proper behavior for Android plugins is to use
getContextinstead ofgetActivity, but since not all plugins follow this pattern, this fix provides backward compat to avoid breaking the plugins that don't.Fixes #108193